Extends GasFeePoller to update gas properties for unapproved transaction batches
#5950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a publish batch hook
Co-authored-by: Matthew Walsh <[email protected]>
…:MetaMask/core into feat/add-batch-transaction-approval-type
…-estimate-gas-batch-transaction
…-estimate-gas-batch-transaction
…-estimate-gas-batch-transaction
…s-fee-poller-batch
vinistevam
changed the title
GasFeePoller to update gas properties for unapproved transactionBatchesGasFeePoller to update gas properties for unapproved transaction batches
pedronfigueiredo
previously approved these changes
Jun 18, 2025
matthewwalsh0
requested changes
Jun 18, 2025
| requireApproval: false, | ||
| }, | ||
| ); | ||
| const txMeta = { ...txBatchMeta, txParams: { ...params, from } }; |
There was a problem hiding this comment.
Minor, is it confusing to have this and transactionMeta below? Maybe we call this transactionMetaForGasEstimates?
There was a problem hiding this comment.
Great suggestion, done.
| } | ||
|
|
||
| log( | ||
| 'Found unapproved batch transactions', |
There was a problem hiding this comment.
Minor, transaction batches?
| this.#updateTransactionBatch(batch); | ||
| } | ||
|
|
||
| #updateTransactionBatch(batch: TransactionBatchMeta) { |
There was a problem hiding this comment.
Rather than accepting the full state which can lead to race conditions in future, could we accept a callback like we do with updateTransactionInternal so we only update specific properties?
There was a problem hiding this comment.
You are right, changed this function to accept a callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR extends the
GasFeePollerto track/update gas properties for unapprovedtransactionBatches.Changes
The GasFeePoller now:
transactionBatchesvia#getUnapprovedTransactionBatches.DefaultGasFeeFlow.transaction-batch-updatedevents with updatedgasFeeEstimates.Updates are applied to the
TransactionBatchMetafor each batch, mirroring the behaviour already in place for single transactions.This enhancement ensures that unapproved transaction batches receive timely gas updates similar to individual transactions, improving consistency across transaction types.
References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/5090
Changelog
Checklist