Skip to content

chore: stop quote polling when tx submission has started #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jun 17, 2025

Explanation

This PR adds a stopPollingForQuotes handler to the bridge controller to prevent quotes from refreshing during tx submission. This enables "pausing" the quote polling loop without resetting the entire state. Without this, it's possible for the activeQuote to change while the UI's tx submission is in-progress

This only needs to be called from submitTx and doesn't need to be explicitly called from the UI.

For clients: stopPollingForQuotes needs to be added to the bridgeStatusController's allowed actions

References

Fixes https://consensyssoftware.atlassian.net/browse/MMS-2188

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@micaelae micaelae requested a review from a team as a code owner June 17, 2025 23:48
@micaelae micaelae requested a review from a team as a code owner June 18, 2025 00:22
@micaelae micaelae enabled auto-merge (squash) June 18, 2025 15:40
@micaelae micaelae merged commit bdf8582 into main Jun 18, 2025
214 checks passed
@micaelae micaelae deleted the mms-2188-stop-polling-on-submit branch June 18, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants