POC for new flow of documentation #2179
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…sk-docs into feat/quick-start
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
yashovardhan
force-pushed
the
feat/quick-start
branch
from
ef3ccf4 to
2ae8dde
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| files[qsFileLinks.EW_PNP_IOS_USERDETAILVIEW_SWIFT], | ||
| 'Get User Info' | ||
| ), | ||
| }, |
There was a problem hiding this comment.
Bug: Quick Start Builder UI Content Mismatch
The "Get User Info" step in the iOS Quick Start builder's highlightRange call incorrectly uses EW_PNP_IOS_VIEWMODEL_SWIFT as the filename while providing content from EW_PNP_IOS_USERDETAILVIEW_SWIFT. This mismatch causes the UI to display the wrong file's content and results in incorrect code highlighting for this step.
| let match; | ||
|
|
||
| // Reset regex lastIndex to avoid stateful issues | ||
| regex.lastIndex = 0; |
There was a problem hiding this comment.
Bug: Unescaped User Input Causes Regex Errors
The highlightSearchText function constructs a RegExp directly from user searchInput without escaping special characters. This causes inputs like (, [, or + to throw an "Invalid regular expression" error, crashing the Guides card component. Escape search terms before building the regex to prevent runtime errors.
Adds the following:
Max time was spent on maintaining the same design scheme, although a design review will be ideal