Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/test-dapp to ^8.3.0 #23463

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Mar 13, 2024

Description

Bumps the test dapp version to fix a broken e2e test with the new provider v16.0.0 version being adopted here

Open in GitHub Codespaces

Related issues

See: MetaMask/test-dapp#301
See: #23375

Manual testing steps

No user facing changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jiexi jiexi changed the title bump @metamask/test-dapp to ^8.3.0 bump @metamask/test-dapp to ^8.3.0 Mar 13, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title bump @metamask/test-dapp to ^8.3.0 chore: bump @metamask/test-dapp to ^8.3.0 Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (845b7b3) to head (4d156a3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23463   +/-   ##
========================================
  Coverage    68.79%   68.79%           
========================================
  Files         1125     1125           
  Lines        43570    43570           
  Branches     11655    11655           
========================================
  Hits         29971    29971           
  Misses       13599    13599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2d2300d]
Page Load Metrics (917 ± 450 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682221163818
domContentLoaded116727168
load552350917937450
domInteractive116727168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jiexi jiexi marked this pull request as ready for review March 13, 2024 17:49
@jiexi jiexi requested a review from a team as a code owner March 13, 2024 17:49
@metamaskbot
Copy link
Collaborator

Builds ready [47b8e7c]
Page Load Metrics (860 ± 413 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691931203718
domContentLoaded108428178
load561998860860413
domInteractive108428178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jiexi jiexi merged commit b3a327d into develop Mar 13, 2024
66 of 67 checks passed
@jiexi jiexi deleted the jl/bump-test-dapp-8.3.0 branch March 13, 2024 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4d156a3]
Page Load Metrics (556 ± 387 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint731731142914
domContentLoaded137028178
load592131556805387
domInteractive137028178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants