Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snaps): Added support for form property in Snap footer buttons #27158

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ritave
Copy link
Member

@ritave ritave commented Sep 16, 2024

Description

This PR adds changes required to enable Snaps' footer buttons to submit and reset forms.

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/snaps#2691

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ritave ritave requested a review from a team as a code owner September 16, 2024 08:36
@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 16, 2024
@Mrtenz Mrtenz requested review from a team and kumavis as code owners September 16, 2024 11:02
@ritave ritave merged commit 70e940a into mrtenz/bump-snaps-packages Sep 16, 2024
16 of 18 checks passed
@ritave ritave deleted the ritave/form branch September 16, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants