Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hook in Portfolio Entry Points #27607

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from
Open

feat: Hook in Portfolio Entry Points #27607

wants to merge 51 commits into from
+238 −90

Conversation

julesat22
Copy link
Contributor

@julesat22 julesat22 commented Oct 3, 2024 •
edited by ziad-saab
Loading

Description

  1. What is the reason for the change?
    Portfolio has requested to add in some entry points into the extension, so users can easily navigate to the Portfolio to view/ manage their spending caps.
  2. What is the improvement/solution?
    This adds value for the users who would like to view/ manage their spending caps as well as their portfolio.

Open in GitHub Codespaces

Manual testing steps

  1. Connect an account
  2. Go to this the assets page in the extension
  3. Click on an asset
  4. Under "Token details", there should be a category for all native and non-native token types for "Spending caps"
  5. Next to Spending caps, check the there is a link that routes the user to the portfolio with the "spendingCaps" tab and the user's account address passed as query params
  6. Check that the link redirects to Portfolio

Screenshots/Recordings

Before

Screenshot 2024-10-03 at 10 45 22 AM

After

Screenshot 2024-10-03 at 9 37 54 AM Screenshot 2024-10-03 at 9 33 21 AM Screenshot 2024-10-03 at 9 32 20 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@julesat22 julesat22 requested review from a team as code owners October 3, 2024 17:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@julesat22 julesat22 changed the title Hook in Portfolio "Spending Caps" Entry Points ferat: Hook in Portfolio "Spending Caps" Entry Points Oct 3, 2024
@julesat22 julesat22 changed the title ferat: Hook in Portfolio "Spending Caps" Entry Points feat: Hook in Portfolio "Spending Caps" Entry Points Oct 3, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4810377]
Page Load Metrics (1725 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31819651666334160
domContentLoaded15211926170412459
load15291979172512862
domInteractive159741209
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.88 KiB (0.03%)
  • common: 133 Bytes (0.00%)

@jclancy93
Copy link
Contributor

image
The gap when the token list section is shown looks like it's less than other sections. The way folks have added padding/margins in this section looks inconsistent but adding a 6px margin top seems to make things look less cramped

@metamaskbot
Copy link
Collaborator

Builds ready [72392f5]
Page Load Metrics (1861 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint153624971865253122
domContentLoaded152824271828226109
load153624961861243117
domInteractive20104502311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.88 KiB (0.02%)
  • common: 133 Bytes (0.00%)

@julesat22
Copy link
Contributor Author

julesat22 commented Oct 15, 2024 •
edited
Loading

image The gap when the token list section is shown looks like it's less than other sections. The way folks have added padding/margins in this section looks inconsistent but adding a 6px margin top seems to make things look less cramped

Great catch, updated and a screenshot has been added to the overview that reflects the spacing changes

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4ea1623]
Page Load Metrics (1918 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16432342191618890
domContentLoaded16022259188318086
load16432370191819393
domInteractive24175523316
backgroundConnect7117352613
firstReactRender502041003015
getState45615157
initialActions01000
loadScripts11561728138914871
setupStore1178342412
uiStartup17982625214920498
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.3 KiB (0.02%)
  • common: 85 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [4b14945]
Page Load Metrics (1768 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15462086176912862
domContentLoaded15312002173811756
load15482085176812862
domInteractive2411149199
backgroundConnect1285332311
firstReactRender48193863215
getState54815136
initialActions01000
loadScripts11051499127910148
setupStore1189292311
uiStartup17042309196715474
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.3 KiB (0.02%)
  • common: 85 Bytes (0.00%)

GuiBibeau
GuiBibeau previously approved these changes Nov 7, 2024
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [2a70fe6]
Page Load Metrics (1728 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31628741671418201
domContentLoaded152628381701279134
load155028761728281135
domInteractive16222464220
backgroundConnect665292010
firstReactRender45204943015
getState4481095
initialActions01000
loadScripts109223701256272130
setupStore589152110
uiStartup169031121918300144
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.3 KiB (0.02%)
  • common: 85 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [adac4da]
Page Load Metrics (2046 ± 129 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint176230862050268128
domContentLoaded175730702018266128
load176230892046269129
domInteractive1799512311
backgroundConnect897302512
firstReactRender972991334722
getState45515136
initialActions01000
loadScripts12822093146817986
setupStore687172110
uiStartup199033162294285137
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.27 KiB (0.02%)
  • common: 85 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [a498e91]
Page Load Metrics (2364 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41929452179677325
domContentLoaded186828822336348167
load188929212364341164
domInteractive36169843216
backgroundConnect1186312110
firstReactRender853011314923
getState665252010
initialActions01000
loadScripts134521701739278133
setupStore76619188
uiStartup206832272647399192
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.27 KiB (0.02%)
  • common: 85 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [05d9935]
Page Load Metrics (1909 ± 219 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89720591758216104
domContentLoaded164337581873440211
load167438581909455219
domInteractive17148604019
backgroundConnect9127332914
firstReactRender532961336732
getState482272512
initialActions01000
loadScripts117429771386371178
setupStore65110115
uiStartup184343102191519249
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.27 KiB (0.02%)
  • common: 85 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziad-saab ziad-saab ziad-saab left review comments

@legobeat legobeat Awaiting requested review from legobeat

@sethhrbek sethhrbek Awaiting requested review from sethhrbek

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

@darkwing darkwing Awaiting requested review from darkwing

@GuiBibeau GuiBibeau Awaiting requested review from GuiBibeau

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-portfolio
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@julesat22 @metamaskbot @jclancy93 @darkwing @ziad-saab @georgewrmarshall @GuiBibeau @sethhrbek @legobeat