-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multichain AssetList
#28386
Open
gambinish
wants to merge
214
commits into
develop
Choose a base branch
from
feat/mmassets-432_network-filter-extension--integration-balances
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Multichain AssetList
#28386
gambinish
wants to merge
214
commits into
develop
from
feat/mmassets-432_network-filter-extension--integration-balances
+1,281
−591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g custom filter logic
…om:MetaMask/metamask-extension into feat/mmassets-432_network-filter-extension
…om:MetaMask/metamask-extension into feat/mmassets-432_network-filter-extension
…function signature
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
## **Description** This PR introduces some non-breaking patterns from #28386 The idea is to introduce this as a smaller PR to reduce the diff in #28386 to make it easier to review [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28429?quickstart=1) ## **Related issues** Fixes: N/A ## **Manual testing steps** App should be fully functional with no regressions ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: chloeYue <[email protected]> Co-authored-by: seaona <[email protected]> Co-authored-by: Monte Lai <[email protected]> Co-authored-by: Charly Chevalier <[email protected]> Co-authored-by: Pedro Figueiredo <[email protected]>
Base automatically changed from
feat/mmassets-432_network-filter-extension--prep-updates
to
develop
November 14, 2024 07:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is currently ready for Alpha version testing. There are still several known issues related to blocking backend dependencies before we can fully merge this into
develop
. These backend dependencies enable cross chain polling, and are being included via NPM as a preview build until an official core release gets cut. For instance, one of these dependencies is: MetaMask/core#4782Additionally, there are integration changes that need to be made on the client. Some of these changes are incorporated into this PR, such as #28276 which integrates cross chain balance polling with it's corresponding core PR.
Once these dependent PRs get merged, the diff in this PR should theoretically become much smaller.
Known issues:
marketData
is not prepopulated across chains. In order to see all of your tokens, on your first app load, you may need to first switch between all of your added networks so that themarketData
from each network gets loaded into state.Related issues
Fixes: https://github.com/orgs/MetaMask/projects/85/views/35?pane=issue&itemId=82217837
Manual testing steps
These are the happy paths we are currently ready to start QA:
yarn && FILTER_TOKENS_TOGGLE=1 yarn webpack --watch
Screenshots/Recordings
Screen.Recording.2024-11-11.at.4.15.34.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist