Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds Solana support for the account overview #28411

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Nov 11, 2024

Description

We added support for the Solana account overview. Now when we select a Solana address the user will be able to see its details in the home view.
Also since the overview is the same for SOL and BTC, in order to not repeat components, we've renamed as "non-evm" the existing BTC ones, and reused them.

Screenshot 2024-11-13 at 13 53 42

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-sol PRs from the Solana snap team label Nov 11, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Nov 12, 2024

@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [9d4e4f2]
Page Load Metrics (2087 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28025621818660317
domContentLoaded17252506205419995
load17392563208720297
domInteractive268751178
backgroundConnect786332713
firstReactRender663901287335
getState563262110
initialActions01000
loadScripts12401996152219694
setupStore55715178
uiStartup193228282351247119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 19.01 KiB (0.31%)
  • ui: 622 Bytes (0.01%)
  • common: 907 Bytes (0.01%)

@zone-live zone-live marked this pull request as ready for review November 13, 2024 13:10
@zone-live zone-live requested review from a team as code owners November 13, 2024 13:10
@zone-live zone-live changed the title chore: adds SOL support chore: adds Solana support for the account overview Nov 13, 2024
@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants