test: [POM] Migrate vault decryption e2e tests to TS and Page Object Model

[chloeYue]

Description

• Migrate e2e tests test/e2e/vault-decryption-chrome.spec.js to TS and Page Object Model, this test runs only on develop branch, by migrating to POM, we improve the maintainability.
• Create page classe functions for vault decryption page, so we can use that in the future when needed
• Deprecate/remove old functions in helper.js
• Improved testing logs to make it easier to debug. See testing logs on this branch:

Related issues

Fixes: #28431

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [c1e6432]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1908 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	310	2295	1743	472	226
		domContentLoaded	1617	2282	1882	187	90
		load	1650	2297	1908	198	95
		domInteractive	16	184	54	34	16
		backgroundConnect	9	101	31	25	12
		firstReactRender	59	328	128	65	31
		getState	5	64	16	16	8
		initialActions	0	1	0	0	0
		loadScripts	1161	1758	1394	172	83
		setupStore	6	75	17	21	10
		uiStartup	1857	2995	2181	274	132

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [b18fee1]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2138 ± 186 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	901	3443	2050	452	217
		domContentLoaded	1731	3430	2106	397	191
		load	1740	3444	2138	388	186
		domInteractive	20	169	63	33	16
		backgroundConnect	8	88	28	23	11
		firstReactRender	74	294	116	44	21
		getState	5	63	26	23	11
		initialActions	0	0	0	0	0
		loadScripts	1240	2823	1571	362	174
		setupStore	6	56	15	16	8
		uiStartup	1936	3680	2379	405	194

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[chloeYue]

intended change: we don't need to check all the wrong answer by default

[metamaskbot]

Builds ready [1fc9eb9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1672 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1509	2005	1693	125	60
		domContentLoaded	1495	1981	1645	100	48
		load	1502	1985	1672	105	50
		domInteractive	22	93	52	21	10
		backgroundConnect	9	77	27	20	10
		firstReactRender	45	307	106	53	25
		getState	4	50	9	11	5
		initialActions	0	1	0	0	0
		loadScripts	1065	1574	1226	100	48
		setupStore	5	77	10	16	7
		uiStartup	1648	2623	1884	201	97

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[DDDDDanica]

LGTM !