Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address design review for NFT token send #28433

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 13, 2024

Description

A few changes were made, namely:

  • Leverage NftItem component to display a square thumbnail of the Nft image
  • Update spending cap indicators to abbreviate long decimal numbers and show complete numbers on a tooltip
  • Center align token name
  • Add # to the token id
  • Change background color for native token fallback thumbnail

Open in GitHub Codespaces

Related issues

Fixes: #28370

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 13, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 13, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title fix: Address design review fix: Address design review for NFT token send Nov 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b246755]
Page Load Metrics (2089 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18422483209117082
domContentLoaded18152421205316278
load18422488208916881
domInteractive15238614723
backgroundConnect1069372110
firstReactRender77156107157
getState56215157
initialActions01000
loadScripts12851817150213565
setupStore65715178
uiStartup20512737230917182
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.28 KiB (0.02%)
  • common: 199 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wallet and dApp initiated Send NFT confirmations
3 participants