fix: fix ConnectPage
when a non-EVM account is selected
#28436
+155
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The currently selected non-EVM account was part of the requested account on during the account connection flow. The
ConnectPage
was allowing to "confirm" the request even if the UI was showing 0 account.To fix this, we no longer uses the currently selected account if this account is not EVM-compatible.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/670
Manual testing steps
yarn start:flask
Screenshots/Recordings
Before
If you try to connect, you will get:
After
Pre-merge author checklist
Pre-merge reviewer checklist