Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove global network from transaction controller #28449

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 13, 2024

Remove multichain flag.
Remove getCurrentChainId usage in background.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove multichain flag.
Remove getCurrentChainId usage in background.
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 13, 2024
Copy link

socket-security bot commented Nov 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Fix unit tests.
Update Lavamoat policies.
@metamaskbot
Copy link
Collaborator

Builds ready [cafd321]
Page Load Metrics (1826 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38621421765343165
domContentLoaded15912126179711455
load16092142182611957
domInteractive17104472210
backgroundConnect96831199
firstReactRender5511796147
getState55312105
initialActions00000
loadScripts1153153213289546
setupStore65917209
uiStartup17882350203912761
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -241 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -2.73 KiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants