Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cross chain swap STX #28460

Draft
wants to merge 12 commits into
base: mb893-cross-chain-swap-tx-status-2
Choose a base branch
from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Nov 14, 2024

Description

This PR improves support for Smart Transactions (STX). It will not show the STX status page if the tx is a Bridge tx. Instead users will be immediately sent to the Activity list. If the user opens the Bridge tx detaills, they should be able to see the proper info.

Also, note that the tx details page is keyed either by the txMeta.id or the txMeta.hash. For an STX we don't have the hash immediately, but in either case we can still look up the relevant info.

Open in GitHub Codespaces

Related issues

Depends on MetaMask/core#4918

Manual testing steps

  1. Go to Settings > Advanced, make sure Smart Transactions is on
  2. Switch network to Ethereum
  3. Go to Bridge
  4. Selection source network, source token, dest network, dest token
  5. Request a quote
  6. Execute a bridge
  7. Go to Activity
  8. Click on the Bridge tx

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Nov 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 267 kB metamaskbot
npm/@metamask/[email protected] None +1 667 kB danfinlay, gudahtt, kumavis, ...7 more

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

@infiniteflower infiniteflower force-pushed the mb893-cross-chain-swap-tx-status-2 branch from 3d57b48 to c1adb80 Compare November 14, 2024 16:03
@infiniteflower infiniteflower changed the title Mb1571 cross chain swap stx feat: Mb1571 cross chain swap STX Nov 14, 2024
@infiniteflower infiniteflower changed the title feat: Mb1571 cross chain swap STX feat: cross chain swap STX Nov 14, 2024
@infiniteflower infiniteflower force-pushed the mb1571-cross-chain-swap-stx branch 2 times, most recently from 7872acb to dbe68bd Compare November 14, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants