-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cross chain swap STX #28460
Draft
infiniteflower
wants to merge
12
commits into
mb893-cross-chain-swap-tx-status-2
Choose a base branch
from
mb1571-cross-chain-swap-stx
base: mb893-cross-chain-swap-tx-status-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: cross chain swap STX #28460
infiniteflower
wants to merge
12
commits into
mb893-cross-chain-swap-tx-status-2
from
mb1571-cross-chain-swap-stx
+644
−402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected] |
infiniteflower
force-pushed
the
mb893-cross-chain-swap-tx-status-2
branch
from
November 14, 2024 16:03
3d57b48
to
c1adb80
Compare
infiniteflower
force-pushed
the
mb1571-cross-chain-swap-stx
branch
from
November 14, 2024 16:07
4359f25
to
44ac2e3
Compare
infiniteflower
changed the title
Mb1571 cross chain swap stx
feat: Mb1571 cross chain swap STX
Nov 14, 2024
infiniteflower
changed the title
feat: Mb1571 cross chain swap STX
feat: cross chain swap STX
Nov 14, 2024
infiniteflower
force-pushed
the
mb1571-cross-chain-swap-stx
branch
2 times, most recently
from
November 14, 2024 21:06
7872acb
to
dbe68bd
Compare
… txMeta so we can read it from just txMeta if no bridgeHistoryItem
infiniteflower
force-pushed
the
mb1571-cross-chain-swap-stx
branch
from
November 14, 2024 21:22
c082ed0
to
0825eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves support for Smart Transactions (STX). It will not show the STX status page if the tx is a Bridge tx. Instead users will be immediately sent to the Activity list. If the user opens the Bridge tx detaills, they should be able to see the proper info.
Also, note that the tx details page is keyed either by the
txMeta.id
or thetxMeta.hash
. For an STX we don't have the hash immediately, but in either case we can still look up the relevant info.Related issues
Depends on MetaMask/core#4918
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist