Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont poll token prices during onboarding or when locked #28465

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 14, 2024

Description

Fixes an issue where token prices were polled during onboarding, or when the extension is locked.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Start the onboarding process
  2. Open background page in dev console
  3. Verify no requests to price api or crypto compare
  4. Finish onboarding
  5. Verify requests start flowing to price api and crypto compare
  6. lock the wallet
  7. Verify no requests to price api or crypto compare
  8. unlock the wallet
  9. Verify requests start flowing to price api and crypto compare

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron marked this pull request as ready for review November 14, 2024 17:38
@bergeron bergeron requested a review from a team as a code owner November 14, 2024 17:38
@bergeron bergeron added this pull request to the merge queue Nov 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1d77886]
Page Load Metrics (2123 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37924712032408196
domContentLoaded17662434208816077
load17762463212315876
domInteractive289851199
backgroundConnect11106422512
firstReactRender571521072110
getState568242010
initialActions01000
loadScripts13091906155413062
setupStore65817189
uiStartup19842757236217785
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 255 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@bergeron bergeron added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@bergeron bergeron added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@bergeron bergeron added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 1c8bfff Nov 14, 2024
89 checks passed
@bergeron bergeron deleted the brian/dont-poll-during-onboarding-or-locked branch November 14, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants