chore: Bump Snaps packages #29275

FrederikBolding · 2024-12-17T13:34:40Z

Description

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:

Allow async initialization logic for Snap bundles
Add onSettingsPage export
Add Banner component
Support size prop on Button
Support fontWeight prop on Text
Add loading state for Button
Use BigInt for processing insight chain IDs

Related issues

Closes MetaMask/snaps#2939
Closes MetaMask/snaps#2947
Closes MetaMask/snaps#2874
Closes MetaMask/snaps#2694

socket-security · 2024-12-17T13:37:45Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	60 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	1.66 MB	metamaskbot
npm/@metamask/[email protected]	None	`+1`	6.44 MB	metamaskbot
npm/@metamask/[email protected]	None	`0`	1.34 MB	metamaskbot
npm/@metamask/[email protected]	network	`0`	1.41 MB	metamaskbot
npm/@metamask/[email protected]	network	`0`	1.38 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

## **Description** Add Snap UI Banner component. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29271?quickstart=1) ## **Related issues** Fixes: MetaMask/snaps#2939 ## **Manual testing steps** 1. Install test Snap from the code example provided and check the results. Example Snap code with Banners in the UI: ```typescript <Container> <Box> <Banner title="Success banner" severity="success"> <Text> <Icon name="arrow-right" color="primary" size="inherit" />  Here is the banner content! </Text> <Bold>Banner bold formatted text</Bold> <Italic>Banner italic formatted text</Italic> <Text> You can click here:  <Link href="https://snaps.metamask.io/">Banner link</Link> </Text> <Button type="button">Banner Action Button</Button> </Banner> <Banner title="Info banner" severity="info"> <Text>Here is the banner content!</Text> </Banner> <Banner title="Warning banner" severity="warning"> <Text>Here is the banner content!</Text> </Banner> <Banner title="Danger banner" severity="danger"> <Text>Here is the banner content!</Text> </Banner> </Box> </Container> ``` ## **Screenshots/Recordings** ### **Before** Banner in Snap UI was not available before this PR. Nothing to show here. ### **After** ![Screenshot 2024-12-17 at 12 34 42](https://github.com/user-attachments/assets/bdf291be-b41b-4e0a-964c-218dbd2dae5e) ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-17T14:04:58Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-17T15:01:51Z

Builds ready [2a0e83e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1809 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1494	2091	1817	200	96
		domContentLoaded	1444	2050	1766	205	98
		load	1498	2109	1809	208	100
		domInteractive	23	117	34	21	10
		backgroundConnect	9	111	47	28	13
		firstReactRender	15	102	53	32	15
		getState	5	88	23	21	10
		initialActions	0	1	0	0	0
		loadScripts	1068	1602	1296	181	87
		setupStore	7	90	20	25	12
		uiStartup	1712	2667	2190	275	132

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 217 Bytes (0.00%)
ui: 2.77 KiB (0.03%)
common: 3.39 KiB (0.04%)

## **Description** This PR enables loading button variant for Snaps UI. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28997?quickstart=1) #### Notes - Targets Snaps release integration PR: #29275 ## **Related issues** Fixes: MetaMask/snaps#2694 ## **Related PR dependencies** Snaps monorepo: MetaMask/snaps#2930 ## **Manual testing steps** 1. Create some example Snap for testing and add Snap UI Button with `loading` variant. Example: ```TypeScript <Button variant="loading">Loading button</Button> ``` ## **Screenshots/Recordings** ### **Before** Loading button variant was not available before. ### **After** https://github.com/user-attachments/assets/5afea22c-1951-4475-a908-aa5b97eafb6b ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-12-17T15:48:33Z

Builds ready [70c7e35]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1615 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	225	1921	1497	436	210
		domContentLoaded	1438	1902	1594	127	61
		load	1448	1909	1615	131	63
		domInteractive	23	72	37	18	9
		backgroundConnect	6	78	26	20	9
		firstReactRender	16	108	48	33	16
		getState	4	63	16	18	9
		initialActions	0	1	0	0	0
		loadScripts	988	1407	1154	119	57
		setupStore	6	91	16	23	11
		uiStartup	1636	2704	1973	281	135

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 217 Bytes (0.00%)
ui: 3.03 KiB (0.04%)
common: 3.39 KiB (0.04%)

## **Description** This PR adds a settings section for each preinstalled snaps that exposes a `onSettingsPage` handler [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29234?quickstart=1) ## **Related issues** Fixes: MetaMask/snaps#2874 ## **Manual testing steps** 1. Open MetaMask's settings 2. You should see the preinstalled snaps settings ## **Screenshots/Recordings**  ### **Before** ### **After** ![image](https://github.com/user-attachments/assets/55f4027c-258e-4039-9006-95228cfdca3f) ![image](https://github.com/user-attachments/assets/e05e6964-ac61-49a1-bb28-e8d7d077dadc) ![image](https://github.com/user-attachments/assets/b2db7088-069a-4b83-9740-11f23f36e879) ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

chore: Bump Snaps packages

f0c956e

metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Dec 17, 2024

FrederikBolding and others added 2 commits December 17, 2024 14:50

Add font weight and size props

cbfa436

Update snapshots

2a0e83e

david0xd mentioned this pull request Dec 17, 2024

feat(snaps): Add loading variant to Snap UI button #28997

Merged

7 tasks

FrederikBolding marked this pull request as ready for review December 18, 2024 09:22

FrederikBolding requested review from a team as code owners December 18, 2024 09:22

david0xd approved these changes Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Bump Snaps packages #29275

chore: Bump Snaps packages #29275

FrederikBolding commented Dec 17, 2024 •

edited

Loading

socket-security bot commented Dec 17, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024

metamaskbot commented Dec 17, 2024

metamaskbot commented Dec 17, 2024

chore: Bump Snaps packages #29275

Are you sure you want to change the base?

chore: Bump Snaps packages #29275

Conversation

FrederikBolding commented Dec 17, 2024 • edited Loading

Description

Related issues

socket-security bot commented Dec 17, 2024 • edited Loading

github-actions bot commented Dec 17, 2024

metamaskbot commented Dec 17, 2024

metamaskbot commented Dec 17, 2024

FrederikBolding commented Dec 17, 2024 •

edited

Loading

socket-security bot commented Dec 17, 2024 •

edited

Loading