feat: 12.18.2 #33200
Merged
feat: 12.18.2 #33200
+643
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runway bumped your version to 12.18.2 Co-authored-by: runway-github[bot] <73448015+runway-github[bot]@users.noreply.github.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33198?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-extension-platform
Builds ready [c079d9a]
UI Startup Metrics (1215 ± 66 ms)
Benchmark value 1793 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1786 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1781 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2517 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2082 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2077 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 2053 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 162 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1939 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1633 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 356ms | Sum of p95 exceeds: 374ms Sum of all benchmark exceeds: 730ms |
Cherry-pick #33180 Populate `gas` and `gasPrice` in requests to security alerts API and `PPOMController`. Specifically: - Extract gas properties from `TransactionMeta`. - Remove excess properties from PPOM request such as `networkClientId` and `tabId`. - Wait for controller objects using events instead of `setTimeout` loop. - Remove duplication in unit tests. - Use `MESSAGE_TYPE` constant for RPC method names. [](https://codespaces.new/MetaMask/metamask-extension/pull/33180?quickstart=1) Fixes: [#4968](MetaMask/MetaMask-planning#4968) - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33201?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Matthew Walsh <[email protected]>
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
|
…nections (#33208) - fix: cp-12.18.2 fix extension EIP-1193 connections (#33199) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The [extension-provider](https://github.com/MetaMask/providers/tree/main/src/extension-provider) was unable to connect to the new metamask extension version (12.18.1). Original issue described here. This PR fixes said issue by looking at `remotePort.sender.id` instead of `remotePort.sender.tab.id` as the latter can be set when extensions are connecting as well, while the former is defined for extensions, but not websites ([documentation](https://developer.chrome.com/docs/extensions/reference/api/runtime#type-MessageSender)). <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33199?quickstart=1) ## **Related issues** Fixes: #33166 ## **Manual testing steps** 1. Install [test extension](https://github.com/MetaMask/test-extension) 2. Connect to metamask extension ID 3. Press connect accounts button (sends `eth_requestAccounts`) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/34b075ed-f103-465c-80d5-84161f4cbf83 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Alex Donesky <[email protected]> [7d05da4](7d05da4) Co-authored-by: ffmcgee <[email protected]> Co-authored-by: Alex Donesky <[email protected]>
Builds ready [881fb3f]
UI Startup Metrics (1187 ± 53 ms)
Benchmark value 1730 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1725 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 1248 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1248 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 1670 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 1619 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1391 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1391 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 1370 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1948 exceeds gate value 1935 for firefox webpack home p95 uiStartup Sum of mean exceeds: 126ms | Sum of p95 exceeds: 51ms Sum of all benchmark exceeds: 177ms |
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Cherry-pick: #33203 Patches in MetaMask/snaps@2fcb306 as a hotfix for the RC. This change is currently in-progress to land on main as well. [](https://codespaces.new/MetaMask/metamask-extension/pull/33202?quickstart=1)
Builds ready [ba2e679]
UI Startup Metrics (1196 ± 66 ms)
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Sum of mean exceeds: 3ms | Sum of p95 exceeds: 9ms Sum of all benchmark exceeds: 12ms |
- fix: cp-12.18.2 bump solana to v1.31.1 (#33210) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** https://github.com/MetaMask/snap-solana-wallet/releases/tag/v1.31.0 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33210?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [15801f0](15801f0) Co-authored-by: Alejandro Garcia Anglada <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@metamaskbot update-attributions |
|
Attributions updated |
Builds ready [84e9130]
UI Startup Metrics (1216 ± 58 ms)
Benchmark value 1725 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1721 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 205 exceeds gate value 195 for firefox browserify home p95 domInteractive Sum of mean exceeds: 64ms | Sum of p95 exceeds: 10ms Sum of all benchmark exceeds: 74ms |
|
This has been tested and signed off by @javiergarciavera and @rizvihaider445 |
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Add changelog for hotfixes in 12.18.2 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33221?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
approved these changes
May 28, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/33198?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/33180?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/33201?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/33199?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/33202?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/33210?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/33221?quickstart=1){kind=link}
Builds ready [106905b]
UI Startup Metrics (1250 ± 72 ms)
Benchmark value 1086 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1080 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 837 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1378 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1197 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1187 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 942 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2196 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1740 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1733 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1729 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2459 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 343 exceeds gate value 334 for chrome webpack home p95 firstPaint Sum of mean exceeds: 150ms | Sum of p95 exceeds: 47ms Sum of all benchmark exceeds: 197ms |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 v12.18.2 Testing & Release Quality Process
Hi Team,
As part of our new MetaMask Release Quality Process, here’s a quick overview of the key processes, testing strategies, and milestones to ensure a smooth and high-quality deployment.
📋 Key Processes
Testing Strategy
Conduct regression and exploratory testing for your functional areas, including automated and manual tests for critical workflows.
Focus on exploratory testing across the wallet, prioritize high-impact areas, and triage any Sentry errors found during testing.
Validate new functionalities and provide feedback to support release monitoring.
GitHub Signoff
Issue Resolution
Cherry-Picking Criteria
✅ Signoff Checklist
Each team is responsible for signing off via GitHub. Use the checkbox below to track signoff completion:
Team sign-off checklist
This process is a major step forward in ensuring release stability and quality. Let’s stay aligned and make this release a success! 🚀
Feel free to reach out if you have questions or need clarification.
Many thanks in advance