Skip to content

chore: Remove MMI build #33205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

chore: Remove MMI build #33205

merged 2 commits into from
May 28, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 27, 2025

Description

Remove the MMI build. We're no longer using it.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔒 @MetaMask/extension-security-team (1 files, +0 -4)
  • 📁 .circleci/
    • 📁 scripts/
      • 📄 bundle.sh +0 -4

@metamaskbot
Copy link
Collaborator

Builds ready [0f2c9b3]
UI Startup Metrics (1225 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1225109213446612801335
load105894511836511141163
domContentLoaded105193011756511061153
domInteractive1713106101629
firstPaint740118116841310901148
backgroundConnect94356824
firstReactRender21166172138
getState1463071927
initialActions003001
loadScripts81069393263863910
setupStore85213812
WebpackHomeuiStartup21161683252720622662443
load16381297194114217371866
domContentLoaded16311293192914117301853
domInteractive15115791344
firstPaint1617530055196279
backgroundConnect2713328322653
firstReactRender15343391114305339
getState144196211324
initialActions612962936
loadScripts16281292191914017281841
setupStore3563227119281
FirefoxBrowserifyHomeuiStartup13151147182512913461659
load11641015156211411931448
domContentLoaded11641015156211411921448
domInteractive96422563397164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313196232045
firstReactRender24216262332
getState84436814
initialActions001001
loadScripts1145998154510911751404
setupStore7410111610
WebpackHomeuiStartup15631362219215816241930
load13391166194814214091588
domContentLoaded13391166194714214091587
domInteractive82572192385119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23156592347
firstReactRender40295144247
getState125238231028
initialActions001011
loadScripts13201151193014213931571
setupStore13524031824
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 36 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 281 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 6ms | Sum of p95 exceeds: 222ms
Sum of all benchmark exceeds: 228ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: -132 Bytes (0%)

@Gudahtt Gudahtt marked this pull request as ready for review May 27, 2025 15:42
@Gudahtt Gudahtt requested review from a team as code owners May 27, 2025 15:42
Copy link
Contributor

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does app/scripts/controllers/institutional-snap/InstitutionalSnapController.ts need to be removed?

@Gudahtt
Copy link
Member Author

Gudahtt commented May 27, 2025

Does app/scripts/controllers/institutional-snap/InstitutionalSnapController.ts need to be removed?

Nope, the institutional snap is our replacement for the MMI build. That is still required.

Remove the MMI build. We're no longer using it.
@Gudahtt Gudahtt force-pushed the remove-mmi-build branch from 0f2c9b3 to 72651fc Compare May 27, 2025 16:16
@metamaskbot
Copy link
Collaborator

Builds ready [0ee80a3]
UI Startup Metrics (1193 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1193106513666312221318
load102893711656110621145
domContentLoaded102191411606110571138
domInteractive16133441527
firstPaint82572116436810551146
backgroundConnect74334713
firstReactRender20165052031
getState1464681931
initialActions001001
loadScripts78568792260826899
setupStore75152812
WebpackHomeuiStartup22111791269323923962598
load17051351208117818441978
domContentLoaded16991347206517618401968
domInteractive161164101347
firstPaint1636441269197302
backgroundConnect2610151173056
firstReactRender16545384112305343
getState194323411533
initialActions612952945
loadScripts16951346205417418311957
setupStore3473206624300
FirefoxBrowserifyHomeuiStartup13381135169910913881568
load11841006154011012401425
domContentLoaded11841006154011012401425
domInteractive994018829116168
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313132162165
firstReactRender24204632429
getState75162810
initialActions002001
loadScripts1163991151911112211401
setupStore74355716
WebpackHomeuiStartup15191306195914416031788
load13141145173913814171563
domContentLoaded13141144173913814171563
domInteractive79332582584129
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20148082231
firstReactRender37286354045
getState10427227812
initialActions002111
loadScripts12961127172513814011544
setupStore85243816
Benchmark value 826 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 2212 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2598 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore
Sum of mean exceeds: 49ms | Sum of p95 exceeds: 379ms
Sum of all benchmark exceeds: 428ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: -132 Bytes (0%)

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue May 27, 2025
@Gudahtt Gudahtt enabled auto-merge May 27, 2025 18:43
@Gudahtt Gudahtt added this pull request to the merge queue May 28, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 28, 2025
Merged via the queue into main with commit e92010b May 28, 2025
155 of 156 checks passed
@Gudahtt Gudahtt deleted the remove-mmi-build branch May 28, 2025 08:55
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
@metamaskbot metamaskbot added the release-12.21.0 Issue or pull request that will be included in release 12.21.0 label May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.21.0 Issue or pull request that will be included in release 12.21.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants