-
Notifications
You must be signed in to change notification settings - Fork 5.2k
chore: Remove MMI build #33205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove MMI build #33205
Conversation
✨ Files requiring CODEOWNER review ✨🔒 @MetaMask/extension-security-team (1 files, +0 -4)
|
Builds ready [0f2c9b3]
UI Startup Metrics (1225 ± 66 ms)
Benchmark value 36 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 281 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 6ms | Sum of p95 exceeds: 222ms Sum of all benchmark exceeds: 228ms Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does app/scripts/controllers/institutional-snap/InstitutionalSnapController.ts
need to be removed?
Nope, the institutional snap is our replacement for the MMI build. That is still required. |
Remove the MMI build. We're no longer using it.
Builds ready [0ee80a3]
UI Startup Metrics (1193 ± 63 ms)
Benchmark value 2212 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2598 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore Sum of mean exceeds: 49ms | Sum of p95 exceeds: 379ms Sum of all benchmark exceeds: 428ms Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Remove the MMI build. We're no longer using it.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist