-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Feat: New srp flow welcome page #33227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+2,307
−1,915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added terms of use - fixed MMPoly font and MMSans
…feat/srp-flow-preferences
…/srp-flow-locales
… feat/srp-flow-terms-of-use
…feat/srp-flow-locales
…/srp-flow-terms-of-use
…/srp-flow-welcome
…feat/srp-flow-locales
…/srp-flow-terms-of-use
… feat/srp-flow-welcome
- use modal align center - fix terms reach bottom
use useCallback when needed
- use Box instead of div
…extension into feat/srp-flow-welcome
- update social login button radius - allow closing terms of use modal
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
- keep old metametrics flow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Welcome page UI
added terms of use
fixed MMPoly font and MMSans
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist