-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added icon to walletconnect metadata #10786
fix: added icon to walletconnect metadata #10786
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use a local image instead of fetching one online?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
Description
Added icon link to WalletConnect metadata. It's useful for dapps that shows the connected wallet info.
Using the image uploaded in this repository -> https://github.com/MetaMask/metamask-mobile/blob/main/logo.png
Related issues
Manual testing steps
Screenshots/Recordings
The images show a dapp that uses the metadata to show connected wallet's name and icon
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist