Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added icon to walletconnect metadata #10786

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

ignaciosantise
Copy link
Contributor

Description

Added icon link to WalletConnect metadata. It's useful for dapps that shows the connected wallet info.
Using the image uploaded in this repository -> https://github.com/MetaMask/metamask-mobile/blob/main/logo.png

Related issues

  • none

Manual testing steps

  • none

Screenshots/Recordings

The images show a dapp that uses the metadata to show connected wallet's name and icon

Before

before

After

after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ignaciosantise ignaciosantise marked this pull request as ready for review August 23, 2024 19:51
@ignaciosantise ignaciosantise requested a review from a team as a code owner August 23, 2024 19:51
@andreahaku andreahaku self-assigned this Aug 26, 2024
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use a local image instead of fetching one online?

app/core/AppConstants.ts Show resolved Hide resolved
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added team-sdk SDK team needs-smoke-e2e release-7.31.0 Issue or pull request that will be included in release 7.31.0 labels Aug 28, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Nov 26, 2024
@christopherferreira9 christopherferreira9 removed the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Nov 26, 2024
@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Nov 26, 2024
@christopherferreira9 christopherferreira9 added Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed Run Smoke E2E Triggers smoke e2e on Bitrise needs-smoke-e2e labels Nov 28, 2024
@christopherferreira9 christopherferreira9 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into MetaMask:main with commit ffe45d0 Nov 28, 2024
46 of 47 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants