Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nodejs 20.18.0 #11953

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: nodejs 20.18.0 #11953

wants to merge 2 commits into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 22, 2024

Description

Bump nodejs version to 20.18.0

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review October 22, 2024 13:31
@legobeat legobeat requested a review from a team as a code owner October 22, 2024 13:31
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 22, 2024
@legobeat legobeat requested review from a team as code owners October 22, 2024 13:35
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 22, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to bump here as well

@legobeat
Copy link
Contributor Author

I think we need to bump here as well

Do we actually need to? I don't think it makes a difference? Updated now in any case!

tommasini
tommasini previously approved these changes Oct 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.48%. Comparing base (ead35c4) to head (9ff7d02).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11953      +/-   ##
==========================================
+ Coverage   55.35%   55.48%   +0.13%     
==========================================
  Files        1767     1772       +5     
  Lines       39841    39931      +90     
  Branches     4965     4974       +9     
==========================================
+ Hits        22052    22157     +105     
+ Misses      16274    16258      -16     
- Partials     1515     1516       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the nodejs-20 branch 3 times, most recently from 0b0fa9b to 749c30d Compare October 30, 2024 00:08
auto-merge was automatically disabled November 5, 2024 02:33

Head branch was pushed to by a user without write access

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
@mcmire
Copy link
Contributor

mcmire commented Nov 19, 2024

@legobeat Do you think this is still necessary? We upgraded to 20.17 recently: #12150

@NicolasMassart NicolasMassart marked this pull request as draft December 3, 2024 09:32
@NicolasMassart NicolasMassart self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file external-contributor Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

6 participants