-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: nodejs 20.18.0 #11953
base: main
Are you sure you want to change the base?
chore: nodejs 20.18.0 #11953
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to bump here as well
Do we actually need to? I don't think it makes a difference? Updated now in any case! |
1e7703a
to
0eccafb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11953 +/- ##
==========================================
+ Coverage 55.35% 55.48% +0.13%
==========================================
Files 1767 1772 +5
Lines 39841 39931 +90
Branches 4965 4974 +9
==========================================
+ Hits 22052 22157 +105
+ Misses 16274 16258 -16
- Partials 1515 1516 +1 ☔ View full report in Codecov by Sentry. |
0b0fa9b
to
749c30d
Compare
Head branch was pushed to by a user without write access
Description
Bump nodejs version to 20.18.0
Related issues
Unblocks: fix: replace legacy eth-json-rpc deps #11952(it was discussed that it should not be a blocker for fix: replace legacy eth-json-rpc deps #11952)Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist