fix: migrate from deprecated legacy packages

[legobeat]

Description

• fix: migrate from ethjs to @metamask/ethjs
• fix(deps): unpin [email protected],x [email protected]
• fix(deps): unpin [email protected]
• fixup ethjs upgrade
• deps: [email protected]>^4.2.2
• fixup ethjs upgrade
• deps: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0
• deps: eth-json-rpc-middleware@^4.4.1->^7.0.1
• deps: [email protected]>^5.1.0

Related issues

• fix: replace legacy eth-json-rpc deps #11952

Blocked by / broken out into

• fix(deps): unpin [email protected],x [email protected] #11972
  • fix(deps): ethereumjs-util@6->^7.1.5 #11932
    • fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979
• fix: @metamask/providers@16, @metamask/json-rpc-middleware-stream@8 #12085
• fix: migrate from legacy ethjs to @metamask/ethjs #11969

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	0	13.9 kB	types
npm/[email protected]	None	0	27 kB	gudahtt
npm/[email protected]	network	+1	130 kB	rekmarks
npm/[email protected]	None	0	22.3 kB	gudahtt

🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/[email protected]	Module: globalThis["fetch"] Location: Package overview	package.json yarn.lock	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5d81074
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/885211b6-0973-4bb6-b0b7-b125f6589328

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise