-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable wallet buttons for accounts that cannot sign transactions #12145
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 7ad62d7 Note
Tip
|
c0268df
to
22bd9cd
Compare
Bitrise❌❌❌ Commit hash: 22bd9cd Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left two small comments
22bd9cd
to
285dfa8
Compare
Bitrise❌❌❌ Commit hash: 285dfa8 Note
Tip
|
285dfa8
to
abc306a
Compare
Bitrise❌❌❌ Commit hash: abc306a Note
Tip
|
Quality Gate passedIssues Measures |
E2E Failing due a known (not related with this PR) issue which is being handled by QA Team. |
Description
This PR disables certain buttons in the WalletActions component when the selected account cannot sign transactions. This change improves the user experience by preventing attempts to perform actions that require transaction signing when the account cannot do so.
The reason for the change is to prevent users from attempting actions that their current account cannot perform.
The improvement is that Buy, Sell, Send, Swap, and Bridge buttons are now disabled when the selected account cannot sign transactions, providing clear visual feedback to the user about available actions.
This work is a continuation of Kate's PR. Since her departure it was easier to start with a fresh branch than rebase her work. Her pr already went through QA and reviews.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/570
Manual testing steps
eth_signTransaction
from the account's methods)Screenshots/Recordings
Before
Wallet view
Asset details view
After
Wallet view
Asset details view
QA
This PR is a direct copy of #11330. Kates change went through several rounds of QA with Mike. His first round found a few issues which were outlined here. Those issues were addressed in subsequent commits and finally QA passed here. All of the code in this PR is a copy of the previous except that I addressed @brianacnguyen's comments. The extra styles that I removed have no effect on the UX since the opacity of 0.5 (correctly applied) has the desired effect on the buttons and makes them appear disabled. This came from a discussion with Brian during a code review.
Pre-merge author checklist
Pre-merge reviewer checklist