Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update swaps quote poll count #12202

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented Nov 6, 2024

Description

Brings the swaps page to parity with extension by increasing the umber of quote refreshes from 2 to 3.

Related issues

Fixes:

Manual testing steps

  1. Go to the swaps
  2. Enter arbitrary swap amounts/tokens
  3. Get quotes
  4. Wait for quotes to refresh 3 times

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Increases the number of quote refreshes from 3 to 4
@bfullam bfullam requested review from a team as code owners November 6, 2024 09:09
Copy link
Contributor

github-actions bot commented Nov 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam bfullam added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (9f29292) to head (17a4f4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12202      +/-   ##
==========================================
+ Coverage   55.78%   56.20%   +0.41%     
==========================================
  Files        1786     1786              
  Lines       40362    40362              
  Branches     5054     5054              
==========================================
+ Hits        22516    22684     +168     
+ Misses      16297    16125     -172     
- Partials     1549     1553       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 27, 2024

@bfullam bfullam added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 756385e Nov 27, 2024
37 checks passed
@bfullam bfullam deleted the MMS-1593-increast-swaps-quote-timeout branch November 27, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants