Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify gitignore to include generated ios/plist files #12209

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

gambinish
Copy link
Contributor

Description

Update gitignore so that we don't need to remember to stash ios configuration after setup.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title chore: Modify gitignore chore: Modify gitignore to include generated ios/plist files Nov 6, 2024
@gambinish gambinish marked this pull request as ready for review November 6, 2024 17:23
@gambinish gambinish requested a review from a team as a code owner November 6, 2024 17:23
Jonathansoufer
Jonathansoufer previously approved these changes Nov 6, 2024
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.gitignore Outdated Show resolved Hide resolved
@gambinish gambinish added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 6, 2024
@gambinish gambinish requested a review from owencraston November 6, 2024 18:37
@gambinish gambinish enabled auto-merge November 6, 2024 18:41
Copy link

sonarcloud bot commented Nov 6, 2024

@gambinish gambinish added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 91757b0 Nov 6, 2024
40 checks passed
@gambinish gambinish deleted the add-plist-to-gitignore branch November 6, 2024 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants