Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update onboarding readme #12287

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Nov 14, 2024

Description

Updates the Google Services section and yarn section of the onboarding README.

Related issues

Fixes: new developer onboarding issues related to google-services configs

Manual testing steps

  1. Try using the readme to onboard as a "new developer"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner November 14, 2024 12:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Nov 14, 2024
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the docs/update-googleservices-onboarding-docs branch from c929407 to a62a65b Compare November 14, 2024 12:10
@Prithpal-Sooriya Prithpal-Sooriya added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 14, 2024
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the docs/update-googleservices-onboarding-docs branch 2 times, most recently from 900b818 to 38d832b Compare November 14, 2024 12:38
update google services section and yarn install sections
@Prithpal-Sooriya
Copy link
Contributor Author

I will resolve comments and add to merge queue tomorrow if no additional comments are made.

Copy link

sonarcloud bot commented Nov 15, 2024

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 24c694c Nov 15, 2024
37 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the docs/update-googleservices-onboarding-docs branch November 15, 2024 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants