-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update onboarding readme #12287
Merged
Prithpal-Sooriya
merged 3 commits into
main
from
docs/update-googleservices-onboarding-docs
Nov 15, 2024
Merged
docs: update onboarding readme #12287
Prithpal-Sooriya
merged 3 commits into
main
from
docs/update-googleservices-onboarding-docs
Nov 15, 2024
+53
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Prithpal-Sooriya
force-pushed
the
docs/update-googleservices-onboarding-docs
branch
from
November 14, 2024 12:10
c929407
to
a62a65b
Compare
Prithpal-Sooriya
added
the
No QA Needed
Apply this label when your PR does not need any QA effort.
label
Nov 14, 2024
Prithpal-Sooriya
force-pushed
the
docs/update-googleservices-onboarding-docs
branch
2 times, most recently
from
November 14, 2024 12:38
900b818
to
38d832b
Compare
update google services section and yarn install sections
Daniel-Cross
approved these changes
Nov 14, 2024
I will resolve comments and add to merge queue tomorrow if no additional comments are made. |
gambinish
approved these changes
Nov 14, 2024
mathieuartu
approved these changes
Nov 14, 2024
Quality Gate passedIssues Measures |
Prithpal-Sooriya
deleted the
docs/update-googleservices-onboarding-docs
branch
November 15, 2024 10:45
metamaskbot
added
the
release-7.37.0
Issue or pull request that will be included in release 7.37.0
label
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.37.0
Issue or pull request that will be included in release 7.37.0
team-notifications
Notifications team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Google Services section and yarn section of the onboarding README.
Related issues
Fixes: new developer onboarding issues related to google-services configs
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist