Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for security alert api #12288

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Nov 14, 2024

Description

Use the mock server to create E2E tests for transactions and signatures to test the Security Alert API responses.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1813

Manual testing steps

  1. Bitrise

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Nov 14, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b26577b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00fd7f8c-8c65-4e63-9a92-1abda5bb591b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam force-pushed the test/add-e2e-security-alert-api branch from b26577b to a5bfdb7 Compare November 15, 2024 09:28
@vinistevam vinistevam force-pushed the test/add-e2e-security-alert-api branch from a5bfdb7 to ab4ad79 Compare November 15, 2024 09:37
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
@vinistevam vinistevam marked this pull request as ready for review November 15, 2024 09:44
@vinistevam vinistevam requested review from a team as code owners November 15, 2024 09:44
Copy link
Contributor

github-actions bot commented Nov 15, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab4ad79
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb6fdcf2-4fd6-4bc3-8602-586d8c693218

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Nov 15, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 29398d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3521eac-a814-4f9a-b394-c97c62263e93

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dab345f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2059204-e12c-4b88-8dd5-5d719304e99b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 29, 2024

@vinistevam vinistevam added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 9b2bcd5 Nov 29, 2024
43 checks passed
@vinistevam vinistevam deleted the test/add-e2e-security-alert-api branch November 29, 2024 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants