Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-827: track additional pooled staking events #12290

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Nov 14, 2024

Description

Adds additional event tracking for pooled-staking tooltips and currency switching.

Related issues

Jira Ticket: STAKE-827: Track more events in Mixpanel

Manual testing steps

note: there's an ongoing issues with tracking events on local dev. Results may vary.

Prerequisite: Add export MM_POOLED_STAKING_UI_ENABLED=true to your local .js.env file

Testing Currency Switch Events

  1. Click on Ethereum in assets list
  2. Click "Stake", "Stake More", or "Unstake" buttons to navigate to the input screen
  3. Switch the currency between native and fiat near the top of the screen

Testing Tooltip Events

  1. Click on Ethereum in assets list
  2. Click on available tooltip icons:
  • Annual rate in the "Your earnings" section within ETH details page
  • Learn more tooltip on the staking input screen
  • Various tooltips on the stake and unstake confirmation views

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Matt561 Matt561 requested review from a team as code owners November 14, 2024 17:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 424d532
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d65f7eeb-aa8f-4dde-bd07-d638082498a7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 14, 2024

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 enabled auto-merge November 14, 2024 18:49
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for @MetaMask/design-system-engineers

@Matt561 Matt561 disabled auto-merge November 14, 2024 19:00
@Matt561 Matt561 enabled auto-merge November 14, 2024 19:01
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Let's follow up + create ticket for either removing withMetaMetrics so we won't have to manage another piece and/or update the existing useMetrics and withMetricsAwareness code

@Matt561 Matt561 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 7b9bd02 Nov 14, 2024
39 of 40 checks passed
@Matt561 Matt561 deleted the feat/stake-827-track-more-events-in-mixpanel branch November 14, 2024 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants