Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow for higher versions of ruby #12292

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 14, 2024

Description

This PR allows for higher versions of ruby >=3.1.6 to be used

Related issues

Fixes:

Manual testing steps

  1. Run yarn setup
  2. Command should run successfully

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner November 14, 2024 18:21
@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 14, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform labels Nov 14, 2024
@Cal-L Cal-L enabled auto-merge November 14, 2024 18:21
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e4cb4cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/25e65fe1-77de-401c-9057-98374f3d98d0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 14, 2024

@Cal-L Cal-L added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 22a4989 Nov 14, 2024
49 of 50 checks passed
@Cal-L Cal-L deleted the chore/enable-ruby-versions branch November 14, 2024 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants