fix: transaction reject crash

[matthewwalsh0]

Description

Rejecting a transaction confirmation caused the app to crash.

This was due to Hermes not supporting the recursive nature of the error stack during serialisation.

Resolution:

• Force the use of 7.0.1 of @metamask/rpc-errors since there are no API breaking changes.
• Update the pre-existing patch to target this new version.

Related issues

Fixes: #12240

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bc2b9ec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86ed992f-9f2b-47a4-bdff-17faa07c8d96

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sethkfman]

LGTM

[sleepytanya]

Bitrise build https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/3bc9b0ad9309787a

Confirming fix:

fix.mp4