Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated staking events to use withMetaMetrics helper #12337

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Nov 19, 2024

Description

This PR updates the events added in #12144 to use the withMetaMetrics helper function.

Related issues

Jira Ticket: STAKE-876: Wrap existing Staking events with withMetaMetrics hook

Manual testing steps

Prerequisite: Add export MM_POOLED_STAKING_UI_ENABLED=true to your local .js.env file.

All events can be tested by running through the stake and unstake flows.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Matt561 Matt561 requested review from a team as code owners November 19, 2024 21:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c92e73
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38269887-d523-4518-88d6-6c72dcdaee8d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a2b51f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d72cded3-63d8-4c83-b664-d87289df3b20

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

nickewansmith
nickewansmith previously approved these changes Nov 20, 2024
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all found events using withMetaMetrics are firing.

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7717877
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/32c3f34a-4afa-4a7b-ae8e-f33b00ab54b5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Nov 26, 2024

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 704870e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cfb9133e-b518-442d-a211-508663812390

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 26, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matt561 Matt561 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 4a2b689 Nov 26, 2024
47 of 49 checks passed
@Matt561 Matt561 deleted the feat/stake-876-wrap-existing-staking-events-with-withmetametrics-hook branch November 26, 2024 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants