-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated staking events to use withMetaMetrics helper #12337
feat: updated staking events to use withMetaMetrics helper #12337
Conversation
…with-withmetametrics-hook
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 6c92e73 Note
|
Bitrise✅✅✅ Commit hash: 1a2b51f Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all found events using withMetaMetrics
are firing.
…xisting-staking-events-with-withmetametrics-hook
…with-withmetametrics-hook
Bitrise❌❌❌ Commit hash: 7717877 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: 704870e Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR updates the events added in #12144 to use the
withMetaMetrics
helper function.Related issues
Jira Ticket: STAKE-876: Wrap existing Staking events with withMetaMetrics hook
Manual testing steps
Prerequisite: Add
export MM_POOLED_STAKING_UI_ENABLED=true
to your local.js.env
file.All events can be tested by running through the stake and unstake flows.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist