-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Snaps packages #12350
chore: Bump Snaps packages #12350
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Bitrise✅✅✅ Commit hash: 74ba840 Note
|
This change progresses the issues I was previously experiencing with local snaps but does not resolve them. I am testing the bitcoin snap and when I run it locally I get the following error. Logs:
whats even weirder is that if I navigate to http://localhost:8080/snap.manifest.json on the apps browser I see the manifest data. Steps:
|
648b7b7
to
d45f0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested local snaps and the BDK (via this branch: https://github.com/MetaMask/snap-bitcoin-wallet/pull/354/files) and they both worked. The BDK snap is not working perfectly however it is not throwing errors so I imagine its an issue the the BDK implementation. Local installs seems to work well. Code also looks good to me.
d45f0c5
to
4e6bbf1
Compare
Quality Gate failedFailed conditions |
Bitrise✅✅✅ Commit hash: 4e6bbf1 Note
|
Description
Bumps all Snaps packages to their latest versions and deletes some unnecessary fetch polyfilling code. This fixes an issue where local Snaps would fail to install in the Flask flavor of mobile.