Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Snaps packages #12350

Merged
merged 3 commits into from
Nov 28, 2024
Merged

chore: Bump Snaps packages #12350

merged 3 commits into from
Nov 28, 2024

Conversation

FrederikBolding
Copy link
Member

Description

Bumps all Snaps packages to their latest versions and deletes some unnecessary fetch polyfilling code. This fixes an issue where local Snaps would fail to install in the Flask flavor of mobile.

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Nov 20, 2024
@FrederikBolding FrederikBolding requested review from a team as code owners November 20, 2024 12:47
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 20, 2024
Copy link

socket-security bot commented Nov 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 5.71 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@FrederikBolding FrederikBolding added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 74ba840
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/218590aa-f916-4386-afb4-6424c67a2abb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@owencraston
Copy link
Contributor

This change progresses the issues I was previously experiencing with local snaps but does not resolve them. I am testing the bitcoin snap and when I run it locally I get the following error.

Simulator Screenshot - iPhone 13 mini - 2024-11-20 at 15 29 12

Logs:

[Error: Failed to fetch snap "local:http://localhost:8080": Failed to fetch "http://localhost:8080/snap.manifest.json". Status code: 404..]

whats even weirder is that if I navigate to http://localhost:8080/snap.manifest.json on the apps browser I see the manifest data.

Simulator Screenshot - iPhone 13 mini - 2024-11-20 at 15 26 48

Steps:

  1. Clone Bitcoin repo
  2. checkout the branch fix/allow-mobile. This will allows the dapp to install on mobile which does not have the same in page providerr.
  3. run yarn install && yarn start
  4. open the metamask mobile app in the simulator. Make sure the sim is running on the same machine as the local snap
  5. after onboarding and creating a wallet, open the in app browser and paste the snap site url into the url box. http://localhost:3000/
  6. click connect and see what happens.

@FrederikBolding FrederikBolding force-pushed the fb/snaps-bump-v78 branch 4 times, most recently from 648b7b7 to d45f0c5 Compare November 27, 2024 11:29
owencraston
owencraston previously approved these changes Nov 27, 2024
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested local snaps and the BDK (via this branch: https://github.com/MetaMask/snap-bitcoin-wallet/pull/354/files) and they both worked. The BDK snap is not working perfectly however it is not throwing errors so I imagine its an issue the the BDK implementation. Local installs seems to work well. Code also looks good to me.

Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Coverage on New Code (required ≥ 60%)
58.0% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@FrederikBolding FrederikBolding added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4e6bbf1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2ff8cab0-efbf-413a-a2ee-5d9ec29f9bc2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@FrederikBolding FrederikBolding added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 28, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit bd06be7 Nov 28, 2024
51 of 52 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v78 branch November 28, 2024 13:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants