-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Creating data tree for signed type V1 signatures #12393
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12393 +/- ##
==========================================
+ Coverage 56.41% 56.93% +0.52%
==========================================
Files 1797 1814 +17
Lines 40586 40871 +285
Branches 5097 5172 +75
==========================================
+ Hits 22896 23271 +375
+ Misses 16134 16023 -111
- Partials 1556 1577 +21 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
import { backgroundState } from '../../../../../../util/test/initial-root-state'; | ||
import DataTree from './DataTree'; | ||
|
||
describe('NoChangeSimulation', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo
Description
Adding data tree for typed sign V1 signature request.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3655
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-11-21.at.7.46.00.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist