Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 800c188 fixing a patch to AssetsController #12401

Closed
wants to merge 1 commit into from

Conversation

smilingkylan
Copy link
Contributor

@smilingkylan smilingkylan commented Nov 22, 2024

Description

cherry-pick 800c188

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@smilingkylan smilingkylan changed the title Cherry-pick 800c188 fixing a patch to AssetsController chore: cherry-pick 800c188 fixing a patch to AssetsController Nov 22, 2024
@smilingkylan smilingkylan marked this pull request as ready for review November 22, 2024 20:20
@smilingkylan smilingkylan requested a review from a team as a code owner November 22, 2024 20:20
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Nov 22, 2024
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0b3eaa3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a56ab186-3acc-4d2b-b3a9-2f57ce558863

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman closed this Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform Mobile Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants