feat: add back account syncing - only e2e for now

[mathieuartu]

Description

This PR adds back account syncing related logic.
⚠️ This PR does not enable account syncing. The only environment it's enabled for is E2E for now.

Detailed changes:

• Bump @metamask/profile-sync-controller to v2.0.0
• Add back account syncing effects and hooks.
• Remove the isNotificationsFeatureEnabled() check for the settings page that was used to conditionally display the profile sync toggle. Profile sync is used by notifications, but not only. Account sync is one feature under the profile sync umbrella. This setting toggle will now be shown.
• Add two new UserStorageController state key/values, hasAccountSyncingSyncedAtLeastOnce and isAccountSyncingReadyToBeDispatched
• Add back the notifications Bitrise workflows
• Use the USER_STORAGE_FEATURE_NAMES exported const from @metamask/profile-sync-controller to populate user storage feature names in order to remove magic strings.
• Add support for BATCH DELETE operations in UserStorageMockttpController (used only in E2E tests)

☝️ The identity team recently became the owner of user storage and profile syncing features. In order to keep the number of files changed low in this PR, we'll rename and change folder structure in a subsequent PR.

Related issues

Fixes:

Manual testing steps

User facing changes:

1. Open the app, go to the security settings
2. Switch profile syncing on and off

E2E changes:

1. Build the app for testing
2. Run SmokeNotifications E2E tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	0	49.9 kB	metamaskbot
npm/@metamask/[email protected]	None	0	910 kB	metamaskbot
npm/@metamask/[email protected]	network Transitive: environment	+7	3.08 MB	metamaskbot
npm/@metamask/[email protected]	None	0	439 kB	metamaskbot
npm/@metamask/[email protected]	network	0	1.38 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cf75abe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8de5e9ad-5ef7-4a26-9448-96c8fd8ffe6b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise