-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade transaction controller to get incoming transactions using accounts API #12419
base: refactor/transaction-controller-remove-global-network
Are you sure you want to change the base?
Conversation
Remove usage of Etherscan constants. Update notification to handle new event.
Bitrise❌❌❌ Commit hash: 6e7d2e0 Note
Tip
|
Bitrise❌❌❌ Commit hash: 77e1f90 Note
Tip
|
Bitrise❌❌❌ Commit hash: 3d85274 Note
Tip
|
…into feat/incoming-transactions-accounts-api
Bitrise❌❌❌ Commit hash: 15501d1 Note
Tip
|
Update selector.
Bitrise❌❌❌ Commit hash: 5e79585 Note
Tip
|
Quality Gate failedFailed conditions |
Description
Update
@metamask/transaction-controller
to retrieve incoming transactions using the accounts API rather than Etherscan.Add incoming transaction E2E tests.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist