Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade transaction controller to get incoming transactions using accounts API #12419

Merged
merged 26 commits into from
Dec 11, 2024
Merged

feat: upgrade transaction controller to get incoming transactions using accounts API #12419

merged 26 commits into from
Dec 11, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 25, 2024 •
edited
Loading

Description

Update @metamask/transaction-controller to retrieve incoming transactions using the accounts API rather than Etherscan.

Add incoming transaction E2E tests.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0
Use preview build
33e2207 
Include network client ID in addTransaction calls.
Include network client ID in updateIncomingTransactions calls.
Include network client Id in getNetworkNonce calls.
Update calls to wipeTransactions.
Create global network utils.
Move getGlobalEthQuery to global network utils.
Add network client ID to test data.
@matthewwalsh0
Fix unit tests
7bc1d9b 
Fix Yarn duplication.
@matthewwalsh0
Add global network unit tests
abbaa54 
Fix linting.
@matthewwalsh0
Add network client ID to addTransaction calls
93dde7c
@matthewwalsh0
Update incoming transaction polling
753e7a4
@matthewwalsh0
Add network client ID to Redux transaction
0ec8217
@matthewwalsh0
Use preview build
3d7675d 
Remove usage of Etherscan constants.
Update notification to handle new event.
@matthewwalsh0
Add initial E2E test
d52d8b3
@matthewwalsh0
Add E2E tests
16fb43c
@matthewwalsh0 matthewwalsh0 changed the title feat: upgrade transaction controller to get incoming transactions from accounts API feat: upgrade transaction controller to get incoming transactions using accounts API Nov 25, 2024
@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6e7d2e0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1208d4a6-755a-4635-8bec-b9c98d027cfb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 25, 2024
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 77e1f90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b2a7b07a-a6b0-481e-b8a4-686655daf678

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3d85274
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a20547db-b13e-4a79-9152-732b3dd43739

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 26, 2024
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9225952
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/457878cf-6b41-4450-b390-6a459f3b2935

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 687abdc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec7bf70c-246a-46bb-9f0c-3c2d044c1ec1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 7, 2024
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b9d4e82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f7a2d01e-b0fe-4b37-99a1-6445ce9c0e0e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
34.2% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
@cryptodev-2s cryptodev-2s mentioned this pull request Dec 10, 2024
Closed
@sahar-fehri
Copy link
Contributor

Assets changes LGTM! Thnx!

tommasini
tommasini approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For we can move quicker, we can address the lack of coverage in a follow up PR

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 2d17939 Dec 11, 2024
47 of 48 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/incoming-transactions-accounts-api branch December 11, 2024 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@tommasini tommasini tommasini approved these changes

@OGPoyraz OGPoyraz OGPoyraz left review comments

Assignees
No one assigned
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthewwalsh0 @sahar-fehri @OGPoyraz @vinnyhoward @tommasini @metamaskbot