Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
THIS PR IMPROVED THE UNLOCK TIME (AFTER USER PRESSES UNLOCK UNTIL THE WALLET VIEW), OF 18 SECONDS (debug mode)
Previous unlock duration: ~25 seconds
New unlock duration: ~7 seconds
And from ~10 seconds to ~4 seconds
(Android QA build)!
Previous unlock duration: ~10 seconds
New unlock duration: ~4 seconds
We will be able to drop our baseline on our performance E2E testing, seeing results in this build time that it takes for a cold app start to the wallet view, reducing 30% (1.4 seconds) of the time, compared to last main build (Android)
This PR patch scure-bip39, eth-hd-keyring and keyring controller to use the native aes module instead.
This patch will be replaced for ongoing work on Keyring Controller, key-tree, and eth-hd-keyring
These are the next steps that need to be taken to ship this:
PR smoke e2e pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2fe81597-0389-43e3-87f1-b74b905707f2?tab=workflows
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
(DEBUG)
https://github.com/user-attachments/assets/0d58ae22-84bb-463d-8948-da06649cd303
(QA)
Screen.Recording.2024-11-25.at.23.48.29.mov
After
(DEBUG)
https://github.com/user-attachments/assets/009f2ef4-5239-4944-979a-bd57adcc1d26
(QA)
https://github.com/user-attachments/assets/3e264ce5-0842-480b-b9bf-cfd8c6d34258
Pre-merge author checklist
Pre-merge reviewer checklist