Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decrease unlock time #12421

Closed
wants to merge 1 commit into from
Closed

fix: Decrease unlock time #12421

wants to merge 1 commit into from

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 25, 2024

Description

THIS PR IMPROVED THE UNLOCK TIME (AFTER USER PRESSES UNLOCK UNTIL THE WALLET VIEW), OF 18 SECONDS (debug mode)
Previous unlock duration: ~25 seconds
New unlock duration: ~7 seconds
And from ~10 seconds to ~4 seconds
(Android QA build)!
Previous unlock duration: ~10 seconds
New unlock duration: ~4 seconds

We will be able to drop our baseline on our performance E2E testing, seeing results in this build time that it takes for a cold app start to the wallet view, reducing 30% (1.4 seconds) of the time, compared to last main build (Android)

This PR patch scure-bip39, eth-hd-keyring and keyring controller to use the native aes module instead.

This patch will be replaced for ongoing work on Keyring Controller, key-tree, and eth-hd-keyring

These are the next steps that need to be taken to ship this:

PR smoke e2e pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2fe81597-0389-43e3-87f1-b74b905707f2?tab=workflows

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

(DEBUG)
https://github.com/user-attachments/assets/0d58ae22-84bb-463d-8948-da06649cd303

(QA)

Screen.Recording.2024-11-25.at.23.48.29.mov

After

(DEBUG)
https://github.com/user-attachments/assets/009f2ef4-5239-4944-979a-bd57adcc1d26

(QA)
https://github.com/user-attachments/assets/3e264ce5-0842-480b-b9bf-cfd8c6d34258

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added DO-NOT-MERGE Pull requests that should not be merged team-tiger Tiger team (for tech debt reduction + performance improvements) labels Nov 25, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 25, 2024
@tommasini
Copy link
Contributor Author

Closing this, and following up with this new one: #12428

@tommasini tommasini closed this Nov 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO-NOT-MERGE Pull requests that should not be merged Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant