-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a new unit test to cover for multichain feature flags ON #12442
test: add a new unit test to cover for multichain feature flags ON #12442
Conversation
…s temporary until we remove the feature flag and old code, also set the flags to OFF also in the existing test that was testing the code with FF OFF. Once we remove the feature flags, we can delete the old tests, until then this ensure both side of the code is tested.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 6f87244 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Account permissions is a component that have some actions, we should aim to unit test those with react-testing-library
…he-build-with-ff-on
agreed, thank you Tomas, this was just a first change to the tests of this component, |
Quality Gate passedIssues Measures |
Once we remove the feature flags, we can delete the old tests, until then this ensure both side of the code is tested.
Description
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3664
Manual testing steps
npx jest app/components/Views/AccountPermissions/**
and all tests should passScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist