-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add source when local PPOM fails #12460
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
7a47ee4
to
dda0a6b
Compare
dda0a6b
to
cdf112f
Compare
|
|
Description
This PR fixes an issue where the source property was not being set correctly when an error occurred during local PPOM validation. Previously, if the local PPOM failed, the error handling mechanism would add an error message but omit the source property, making it unclear whether the error originated from the API or the local PPOM.
Changes introduced:
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2058
Manual testing steps
Obs: We need to block the network calls for
https://security-alerts.api.cx.metamask.io/
andhttps://static.cx.metamask.io/api/v1/confirmations/ppom/ppom_version.json
in the Chrome dev tools > network tab.Screenshots/Recordings
security-alerts-local.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist