Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(3615): add new e2e test for initial dapp connection and non permitted flow #12488

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test(3615): add new e2e test for initial dapp connection and non permitted flow #12488

wants to merge 5 commits into from
+250 −2

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Nov 28, 2024 •
edited
Loading

Description

Covers with e2e the scenarios where the user connects an in app browser dapp by granting permissions to one account and one chain, aka initial connection. A second e2e test covers one flow of the none permitted flow.

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2796

Manual testing steps

I have added screenshot below to see how it looks.

  1. yarn watch:clean
  2. yarn test:e2e:ios:debug:build
  3. yarn test:e2e:ios:debug:run e2e/specs/multichain/permission-system-initial-permissions-grant-one-account-and-one-chain.spec.js
  4. For the second scenario, non permitted flow, not shown in the screenshot below, it is permission-system-connect-to-non-permitted-chain.spec

Screenshots/Recordings

2024-11-28 16 47 48

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33
test: e2e scenario where the user connects an in app browser dapp by …
29082aa 
…granting permission to one account and one chain
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 29082aa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e18740a0-22f9-4dc3-a4a9-960ee135f992

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 changed the title test: e2e scenario where the user connects an in app browser dapp by granting permissions to one account and one chain test: add new e2e test for initial dapp connection Nov 28, 2024
@EtherWizard33 EtherWizard33 marked this pull request as ready for review November 28, 2024 21:55
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner November 28, 2024 21:55
@EtherWizard33 EtherWizard33 changed the title test: add new e2e test for initial dapp connection test(3615): add new e2e test for initial dapp connection Nov 28, 2024
@EtherWizard33 EtherWizard33 changed the title test(3615): add new e2e test for initial dapp connection test(3615): add new e2e test for initial dapp connection and non permitted flow Nov 29, 2024
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c2a528a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8cc9253-d4dd-4385-8a7c-a13a616b45a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33
test: add a few steps to the non-permitted network test, as a tempora…
7d99fe4 
…ry way to confirm the permission was added, until we have a e2e way to check if the checkbox corresponding to the added permission was indeed checked
@EtherWizard33
test: add an assertion to the non-permitted network to confirm the ch…
6065766 
…ain perm was indeed added as expected
@EtherWizard33
refactor: split non-permitted flow e2e test into 3 smaller tests
c4c087b
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortisiko cortisiko Awaiting requested review from cortisiko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtherWizard33 @cortisiko