Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add unit tests to feature flags #12503

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

tommasini
Copy link
Contributor

Description

Add unit tests to feature flags controller and useMinimumVersions unit tests updated

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements) labels Nov 29, 2024
@tommasini tommasini requested review from a team as code owners November 29, 2024 19:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Nov 29, 2024

@joaoloureirop joaoloureirop merged commit 5cfbd03 into feat/feature-flags Nov 29, 2024
34 checks passed
@joaoloureirop joaoloureirop deleted the chore/feature-flags-unit-tests branch November 29, 2024 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants