Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-7.41.0 fix main aggregated account balance #13513

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

sahar-fehri
Copy link
Contributor

Description

fixes main aggregated balance

Related issues

Fixes: #13478

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fadc8c9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e0968b28-01eb-42b2-b9a6-e70528f54d9f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sleepytanya
Copy link
Contributor

@sahar-fehri

Builds: https://app.bitrise.io/build/5e1c8dc2-334d-486f-be04-3152b8c1f142?tab=artifacts
Balance looks good for all networks except Linea:

linea_balance.mp4

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review February 14, 2025 09:37
@sahar-fehri sahar-fehri requested a review from a team as a code owner February 14, 2025 09:37
Copy link
Contributor

github-actions bot commented Feb 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f35e521
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/953e1659-f0ea-475b-ace3-0162d4632592

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2025
@sahar-fehri sahar-fehri changed the title fix: fix main aggregated account balance fix: cp-7.41.0 fix main aggregated account balance Feb 14, 2025
@sleepytanya
Copy link
Contributor

sleepytanya commented Feb 14, 2025

@sahar-fehri

Build: https://app.bitrise.io/build/06f4cca3-68ac-4e72-8e61-5db934886dd6?tab=artifacts
Fixed in the latest commit:

Screen_Recording_20250214_101243_MetaMask.mp4

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Feb 14, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit caa5cde Feb 14, 2025
51 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-main-total-account-balance branch February 14, 2025 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. QA Passed A successful QA run through has been done release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
5 participants