Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional app icons and remove tint fields #13544

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

vinnyhoward
Copy link
Contributor

Description

  • Added additional app icons
  • Removed unused tint fields in Contents.json
  • Updated info.plist

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested a review from a team as a code owner February 14, 2025 23:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bfcd669
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb6bdfd5-5619-40c4-b7d2-c08cf864a8b1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit 90787ab Feb 16, 2025
46 of 48 checks passed
@vinnyhoward vinnyhoward deleted the fix-update-app-icons-remove-tint branch February 16, 2025 23:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 16, 2025
@christopherferreira9 christopherferreira9 restored the fix-update-app-icons-remove-tint branch February 19, 2025 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants