Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump deploy to bitrise step to 2.2.3 #13610

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 19, 2025

Description

Bitrise requires that we bump the deploy-to-bitrise step to 2.0.0 or higher by a certain date. This task bumps the ones that are using major version 1.

Deploy to bitrise step - https://bitrise.io/integrations/steps/deploy-to-bitrise-io

Related issues

Fixes:

Manual testing steps

build_ios_release and build_ios_flask_release will continue to work. We can trust that the step works since we're already using 2.2.3 everywhere else.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner February 19, 2025 17:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Feb 19, 2025
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 19, 2025
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@Cal-L Cal-L added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 2abba37 Feb 19, 2025
46 of 50 checks passed
@Cal-L Cal-L deleted the chore/bump-bitrise-deploy-action branch February 19, 2025 18:40
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-mobile-platform Mobile Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants