-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Solana accountChanged event #15561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
An alternative suggeestion
cleanup
…n-router-solana-accountChanged
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
skipping sonar-cloud because coverage artificially lower due to non-functional stylistic changes |
|
still seeing all the accounts selected in the dapp account selector view: Screen.Recording.2025-05-29.at.9.54.37.AM.mov |
Another bug I'm seeing: Screen.Recording.2025-05-29.at.9.58.59.AM.mov |
…n-router-solana-accountChanged
|
|
SolScope.Mainnet, | ||
)?.address; | ||
} catch { | ||
// noop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we place some logs here to help debugging if it comes to it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left 1 non blocking comment, lgtm 🚀
Description
accountChange
supportRelated issues
Fixes:
Manual testing steps
yarn setup
yarn start:ios:flask
Screenshots/Recordings
Before
After
Screen.Recording.2025-05-22.at.2.54.56.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist