Skip to content

feat(deposit): MVP - deposit feature email authentication UX #15568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 26, 2025

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented May 23, 2025

Description

This PR creates the routing and basic MVP login flow UX for the deposit feature. User can click the deposit button to enter the deposit experience, enter an email and an OTP code.

API calls are mocked.

Progress bar is going to be added in another PR.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-05-23.at.11.37.59.mp4

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgeweiler georgeweiler changed the title Feat/deposit email otp scratch Feat/deposit email otp May 23, 2025
Copy link

socket-security bot commented May 23, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​react-native-confirmation-code-field@​7.6.110010010089100

View full report

@georgeweiler georgeweiler added team-ramp issues related to Ramp features No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels May 23, 2025
@georgeweiler georgeweiler marked this pull request as ready for review May 23, 2025 18:23
@georgeweiler georgeweiler requested a review from a team as a code owner May 23, 2025 18:23
@AxelGes
Copy link
Contributor

AxelGes commented May 23, 2025

The header looks slightly different from the one in the designs. I assume this is partly because the designs reflect changes to the Component Library that haven't taken effect yet. However, the "x" button should still be in place for it to match the design structure.

This PR:
image

Design:
image

AxelGes
AxelGes previously approved these changes May 23, 2025
@georgeweiler georgeweiler enabled auto-merge May 23, 2025 21:51
@georgeweiler georgeweiler moved this to Needs dev review in PR review queue May 23, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (e095d11) to head (88316b1).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...pp/components/UI/Deposit/Views/OtpCode/OtpCode.tsx 84.00% 1 Missing and 3 partials ⚠️
app/components/UI/Navbar/index.js 42.85% 4 Missing ⚠️
app/components/UI/Deposit/hooks/useDepositSdk.ts 85.71% 2 Missing ⚠️
...ponents/UI/Deposit/Views/EnterEmail/EnterEmail.tsx 94.11% 1 Missing ⚠️
app/components/UI/Deposit/routes/index.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15568      +/-   ##
==========================================
+ Coverage   69.25%   69.34%   +0.08%     
==========================================
  Files        2434     2462      +28     
  Lines       52417    52695     +278     
  Branches     7930     7978      +48     
==========================================
+ Hits        36304    36542     +238     
- Misses      13786    13807      +21     
- Partials     2327     2346      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgeweiler georgeweiler requested a review from AxelGes May 24, 2025 16:29
@georgeweiler georgeweiler changed the title Feat/deposit email otp feat(deposit): MVP - deposit feature email authentication UX May 26, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 26, 2025
Copy link

@georgeweiler georgeweiler added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 2cae2c3 May 26, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 26, 2025
@georgeweiler georgeweiler deleted the feat/deposit-email-otp-scratch branch May 26, 2025 16:47
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants