User to be able to edit approval amount in simulation section of batched confirmation #15572
+895
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…alanceChanges.test.ts Co-authored-by: OGPoyraz <[email protected]>
…alanceChanges.test.ts Co-authored-by: OGPoyraz <[email protected]>
…styles.ts Co-authored-by: OGPoyraz <[email protected]>
OGPoyraz
requested changes
Jun 2, 2025
app/components/UI/SimulationDetails/EditRowValue/EditRowValue.tsx
Outdated
Show resolved
Hide resolved
...components/Views/confirmations/components/UI/text-field-with-label/text-field-with-label.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/SimulationDetails/BalanceChangeRow/BalanceChangeRow.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/SimulationDetails/BalanceChangeRow/BalanceChangeRow.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: OGPoyraz <[email protected]>
…angeRow.tsx Co-authored-by: OGPoyraz <[email protected]>
…angeRow.tsx Co-authored-by: OGPoyraz <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
OGPoyraz
approved these changes
Jun 2, 2025
|
jpuri
added
No E2E Smoke Needed
metamaskbot
added
the
release-7.48.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User to be able to edit approval amount in simulation section of batched confirmation
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4972
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-05-23.at.6.08.34.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist