User to be able to edit approval amount in simulation section of batched confirmation #15572
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
force-pushed
the
simulation_section
branch
2 times, most recently
from
3fefddc to
e42b19f
Compare
|
|
| "unavailable": "Unavailable", | ||
| "edit_approval_limit_title": "Edit approval limit", | ||
| "edit_approval_limit_description": "Enter the amount that you feel comfortable being spent on your behalf.", | ||
| "edit_approval_limit_balance_info": "Account balance:", | ||
| "cancel": "Cancel", | ||
| "save": "Save" |
| iconName={IconName.Edit} | ||
| size={ButtonIconSizes.Md} | ||
| onPress={openModal} | ||
| testID="edit-amount-button-icon" |
There was a problem hiding this comment.
Initially, the file path name "edit-row-value" suggests this could be a generic edit row component.
Based on the translation keys and methods, it combines the context of simulation and the amount. Can we rename the file path to provide more context?
If we plan for other edit row components, we could abstract the logic later to create a reusable component
| jest.mock('../../../../core/Engine', () => ({ | ||
| context: { | ||
| TokenListController: { | ||
| fetchTokenList: jest.fn(), | ||
| }, | ||
| }, | ||
| })); | ||
|
|
There was a problem hiding this comment.
| jest.mock('../../../../core/Engine', () => ({ | |
| context: { | |
| TokenListController: { | |
| fetchTokenList: jest.fn(), | |
| }, | |
| }, | |
| })); |
I think we can remove this after this PR was merged a few hours ago
#15843
will need to double-check
Description
User to be able to edit approval amount in simulation section of batched confirmation
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4972
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-05-23.at.6.08.34.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist