Skip to content

feat: track multi srp events #15618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: track multi srp events #15618

wants to merge 5 commits into from

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented May 23, 2025

Description

For our new screens on Multi SRP, we should add in new events to track the screens and choices users make.

The metrics we are trying to track are described in this document. I have included a screenshot of the events and flows below. Note, we will not be adding the hd_entropy_index in this change. That will be added in the following PR in order to reduce the scope of this PR.

Screenshot 2025-05-23 at 6 51 15 PM

Related extension PRs:

New events:

Related issues

Resolves: https://consensyssoftware.atlassian.net/browse/MUL-116

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston force-pushed the feat/multi-srp-metrics branch 2 times, most recently from bc28849 to adeceb2 Compare May 26, 2025 13:07
@owencraston owencraston marked this pull request as ready for review May 26, 2025 13:15
@owencraston owencraston requested a review from a team as a code owner May 26, 2025 13:15
onPress={() => {
trackEvent(
createEventBuilder(
MetaMetricsEvents.SECRET_RECOVERY_PHRASE_PICKER_CLICKED,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a another event for selecting a phrase from the picker? Reusing this event may show that the picker is used more than it really is.

@owencraston owencraston force-pushed the feat/multi-srp-metrics branch from 518aef4 to 7eaa61d Compare May 27, 2025 16:31
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants