Skip to content

chore: removing duplicate icons and updating account splash page #15642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

georgewrmarshall
Copy link
Contributor

Description

This PR removes design and tech debt by cleaning up unused icon assets and modernizing the SmartAccountUpdateSplash component implementation.

What is the reason for the change?

  • The previous implementation in PR feat: Adding splash page to upgrade account request #15355 added new filled icon variants (SpeedometerFilled, SparkleFilled, PetrolPump) when existing icons could be used
  • The component was using the older Icon component instead of the modern AvatarIcon component
  • Unused SVG assets were taking up space in the codebase

What is the improvement/solution?

  • Removed 3 unused SVG files and their corresponding imports/enum entries
  • Replaced Icon component with AvatarIcon component for better design consistency
  • Updated icon names to use existing variants: SpeedometerFilled → Speedometer, PetrolPump → Gas, SparkleFilled → Sparkle
  • Added proper theming support with useTheme hook
  • Improved component structure by converting ListItem from arrow function to proper function component

Related issues

Fixes: N/A

Manual testing steps

  1. Navigate to a confirmation flow that triggers the Smart Account Update Splash
  2. Verify that all three list items display with correct icons (speedometer, gas pump, sparkle)
  3. Confirm that icons use proper theming (primary color with muted background)
  4. Test in both light and dark themes to ensure proper color application
  5. Verify that icon functionality and accessibility remain unchanged

Screenshots/Recordings

Before

  • Used filled icon variants (SpeedometerFilled, SparkleFilled, PetrolPump)
  • Used basic Icon component without proper theming
  • Extra SVG files in codebase
Screenshot 2025-05-15 at 3 36 37 PM

After

  • Uses standard icon variants (Speedometer, Gas, Sparkle)
  • Uses modern AvatarIcon component with proper theming
  • Cleaner codebase with removed unused assets
Screenshot 2025-05-24 at 10 26 23 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall requested review from a team as code owners May 24, 2025 01:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label May 24, 2025
@georgewrmarshall georgewrmarshall self-assigned this May 24, 2025
@georgewrmarshall georgewrmarshall added QA in Progress QA has started on the feature. Run Smoke E2E Requires smoke E2E testing labels May 24, 2025
Copy link
Contributor

github-actions bot commented May 24, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b6edbd6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60967fe6-7748-4170-81c5-21f115e55894

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgewrmarshall georgewrmarshall added QA Passed QA testing has been completed and passed and removed QA in Progress QA has started on the feature. labels May 24, 2025
Copy link

@georgewrmarshall georgewrmarshall added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 24, 2025
@georgewrmarshall georgewrmarshall added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@georgewrmarshall georgewrmarshall added Run Smoke E2E Requires smoke E2E testing No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels May 28, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit f6f4594 May 28, 2025
82 of 94 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/account-splash-icons branch May 28, 2025 05:23
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run QA Passed QA testing has been completed and passed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants