Add a test

MetaMask · Aug 21, 2024 · 031019a · 031019a
1 parent 09bcf58
commit 031019a
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 0 deletions.
diff --git a/packages/snaps-controllers/src/snaps/SnapController.test.tsx b/packages/snaps-controllers/src/snaps/SnapController.test.tsx
@@ -4628,6 +4628,65 @@ describe('SnapController', () => {
       snapController.destroy();
     });
 
+    it('grants permitted chains permission to Snaps with `endowment:ethereum-provider`', async () => {
+      const rootMessenger = getControllerMessenger();
+      const messenger = getSnapControllerMessenger(rootMessenger);
+
+      rootMessenger.registerActionHandler(
+        'PermissionController:getPermissions',
+        () => ({}),
+      );
+
+      rootMessenger.registerActionHandler(
+        'SelectedNetworkController:getNetworkClientIdForDomain',
+        () => 'mainnet',
+      );
+
+      rootMessenger.registerActionHandler(
+        'NetworkController:getNetworkClientById',
+        () => ({
+          // @ts-expect-error - Partial network client.
+          configuration: {
+            chainId: '0x1',
+          },
+        }),
+      );
+
+      const { manifest } = await getMockSnapFilesWithUpdatedChecksum({
+        manifest: getSnapManifest({
+          initialPermissions: {
+            'endowment:page-home': {},
+            'endowment:ethereum-provider': {},
+          },
+        }),
+      });
+
+      const snapController = getSnapController(
+        getSnapControllerOptions({
+          messenger,
+          detectSnapLocation: loopbackDetect({ manifest }),
+        }),
+      );
+
+      await snapController.installSnaps(MOCK_ORIGIN, {
+        [MOCK_SNAP_ID]: {},
+      });
+
+      const approvedPermissions = {
+        'endowment:ethereum-provider': {
+          caveats: [],
+        },
+        permittedChains: {},
+      };
+
+      expect(messenger.call).toHaveBeenCalledWith(
+        'PermissionController:grantPermissions',
+        { approvedPermissions, subject: { origin: MOCK_SNAP_ID } },
+      );
+
+      snapController.destroy();
+    });
+
     it('supports preinstalled snaps', async () => {
       const rootMessenger = getControllerMessenger();
       jest.spyOn(rootMessenger, 'call');

diff --git a/packages/snaps-controllers/src/snaps/SnapController.ts b/packages/snaps-controllers/src/snaps/SnapController.ts
@@ -3637,6 +3637,8 @@ export class SnapController extends BaseController<
    */
   #getPermissionsToGrant(snapId: SnapId, newPermissions: RequestedPermissions) {
     if (Object.keys(newPermissions).includes(SnapEndowments.EthereumProvider)) {
+      // This will return the globally selected network if the Snap doesn't have
+      // one set.
       const networkClientId = this.messagingSystem.call(
         'SelectedNetworkController:getNetworkClientIdForDomain',
         snapId,

diff --git a/packages/snaps-controllers/src/test-utils/controller.ts b/packages/snaps-controllers/src/test-utils/controller.ts
@@ -469,6 +469,7 @@ export const getSnapControllerMessenger = (
       'ExecutionService:terminateAllSnaps',
       'ExecutionService:terminateSnap',
       'ExecutionService:handleRpcRequest',
+      'NetworkController:getNetworkClientById',
       'PermissionController:getEndowments',
       'PermissionController:hasPermission',
       'PermissionController:hasPermissions',
@@ -481,6 +482,7 @@ export const getSnapControllerMessenger = (
       'PermissionController:getSubjectNames',
       'PhishingController:maybeUpdateState',
       'PhishingController:testOrigin',
+      'SelectedNetworkController:getNetworkClientIdForDomain',
       'SnapController:get',
       'SnapController:handleRequest',
       'SnapController:getSnapState',