Enable Node16 module resolution

MetaMask · Sep 9, 2024 · 5e3acf1 · 5e3acf1
1 parent 80fc48f
commit 5e3acf1
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 15 deletions.
diff --git a/packages/examples/packages/browserify-plugin/snap.manifest.json b/packages/examples/packages/browserify-plugin/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "86NLlsPJvWJxQuiDRc6479u6RvMaCFIK8GNVpTdcPjI=",
+    "shasum": "sMwND6AEkeKsDGmco0iXwfoit1cF+5ma0IiPttevwlE=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

diff --git a/packages/examples/packages/browserify/snap.manifest.json b/packages/examples/packages/browserify/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "BXW4yp9Qs+yCSXZXMJfvEIjY0epnS2yhzcHZ8kAb0B0=",
+    "shasum": "i4dr8xQTfJM87uTLP9CkRz+ezhPSU1xLl9EeSXuQYuI=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

diff --git a/packages/snaps-sdk/src/types/images.ts → .../examples/packages/images/src/images.d.ts b/packages/snaps-sdk/src/types/images.ts → .../examples/packages/images/src/images.d.ts
@@ -1,15 +1,10 @@
 // eslint-disable-next-line import/unambiguous
-declare module '*.svg' {
-  const content: string;
-  export default content;
-}
-
 declare module '*.png' {
   const content: string;
   export default content;
 }
 
-declare module '*.jpg' {
+declare module '*.svg' {
   const content: string;
   export default content;
 }
diff --git a/packages/snaps-cli/tsconfig.build.json b/packages/snaps-cli/tsconfig.build.json
@@ -3,7 +3,8 @@
   "compilerOptions": {
     "baseUrl": "./",
     "outDir": "./dist",
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "skipLibCheck": true
   },
   "include": ["./src"],
   "exclude": [

diff --git a/packages/snaps-cli/tsconfig.json b/packages/snaps-cli/tsconfig.json
@@ -1,7 +1,8 @@
 {
   "extends": "../../tsconfig.packages.json",
   "compilerOptions": {
-    "baseUrl": "./"
+    "baseUrl": "./",
+    "skipLibCheck": true
   },
   "include": ["./src", "./src/**/*.json", "jest.setup.ts", "package.json"],
   "references": [

diff --git a/packages/snaps-sdk/src/types/index.ts b/packages/snaps-sdk/src/types/index.ts
@@ -1,7 +1,6 @@
 // This is intentionally imported, rather than re-exported.
 /* eslint-disable import/no-unassigned-import */
 import './global';
-import './images';
 /* eslint-enable import/no-unassigned-import */
 
 export * from './caip';

diff --git a/tsconfig.packages.build.json b/tsconfig.packages.build.json
@@ -4,7 +4,6 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "inlineSources": true,
-    "sourceMap": true,
-    "module": "ES2020"
+    "sourceMap": true
   }
 }
diff --git a/tsconfig.packages.json b/tsconfig.packages.json
@@ -6,8 +6,8 @@
     "jsx": "react-jsx",
     "jsxImportSource": "@metamask/snaps-sdk",
     "lib": ["DOM", "ES2020"],
-    "module": "CommonJS",
-    "moduleResolution": "node",
+    "module": "Node16",
+    "moduleResolution": "Node16",
     "paths": {
       "@metamask/*/test-utils": ["../*/src/test-utils"],
       "@metamask/*/node": ["../*/src/node"],